Uploaded image for project: 'VPMS Web Application'
  1. OVPMS-1993

SFS client doesn't handle non-standard http status codes

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects versions: 1.9
    • Fix versions: 2.0
    • Components: None
    • Labels:
      None
    • Sprint:

      Description

      If documents are disabled in SFS, attempting to download a document results a 465 response, with a message "The manager turned off document on the Settings / Documents management page".

      OpenVPMS doesn't handle the non-standard status code correctly, and instead triggers a NullPointerException, masking the original error:

      20 Dec 2017 02:38:27,733 ERROR DialogErrorHandler,http-bio-8080-exec-5180:69 - NLE - An internal application error has occurred.
      javax.ws.rs.ProcessingException
      	at org.glassfish.jersey.client.ClientRuntime.invoke(ClientRuntime.java:264)
      	at org.glassfish.jersey.client.JerseyInvocation$3.call(JerseyInvocation.java:722)
      	at org.glassfish.jersey.internal.Errors.process(Errors.java:315)
      	at org.glassfish.jersey.internal.Errors.process(Errors.java:297)
      	at org.glassfish.jersey.internal.Errors.process(Errors.java:228)
      	at org.glassfish.jersey.process.internal.RequestScope.runInScope(RequestScope.java:444)
      	at org.glassfish.jersey.client.JerseyInvocation.invoke(JerseyInvocation.java:718)
      	at org.glassfish.jersey.client.JerseyInvocation$Builder.method(JerseyInvocation.java:430)
      	at org.glassfish.jersey.client.proxy.WebResourceFactory.invoke(WebResourceFactory.java:345)
      	at com.sun.proxy.$Proxy66.getMedicalRecordsReport(Unknown Source)
      	at org.openvpms.smartflow.client.HospitalizationService$1.getResponse(HospitalizationService.java:217)
      	at org.openvpms.smartflow.client.HospitalizationService.saveReport(HospitalizationService.java:280)
      	at org.openvpms.smartflow.client.HospitalizationService.saveMedicalRecords(HospitalizationService.java:214)
      	at org.openvpms.web.workspace.patient.history.FlowSheetReportsDialog.onOK(FlowSheetReportsDialog.java:130)
      	at org.openvpms.web.echo.dialog.PopupDialog.onButton(PopupDialog.java:313)
      	at org.openvpms.web.echo.dialog.PopupDialog.onButtonProtected(PopupDialog.java:499)
      	at org.openvpms.web.echo.dialog.PopupDialog.access$000(PopupDialog.java:34)
      	at org.openvpms.web.echo.dialog.PopupDialog$4.onAction(PopupDialog.java:486)
      	at org.openvpms.web.echo.event.ActionListener.actionPerformed(ActionListener.java:40)
      	at nextapp.echo2.app.button.AbstractButton.fireActionPerformed(AbstractButton.java:135)
      	at echopointng.ButtonEx$1.actionPerformed(ButtonEx.java:120)
      	at nextapp.echo2.app.button.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:70)
      	at echopointng.model.DefaultButtonModelEx.doAction(DefaultButtonModelEx.java:51)
      	at echopointng.ButtonEx.processInput(ButtonEx.java:202)
      	at nextapp.echo2.app.update.ClientUpdateManager.process(ClientUpdateManager.java:116)
      	at nextapp.echo2.app.update.UpdateManager.processClientUpdates(UpdateManager.java:89)
      	at nextapp.echo2.webcontainer.ContainerSynchronizeService.renderUpdate(ContainerSynchronizeService.java:471)
      	at nextapp.echo2.webrender.service.SynchronizeService.service(SynchronizeService.java:279)
      	at nextapp.echo2.webrender.WebRenderServlet.process(WebRenderServlet.java:273)
      	at org.openvpms.web.echo.servlet.SpringWebContainerServlet.process(SpringWebContainerServlet.java:190)
      	at nextapp.echo2.webrender.WebRenderServlet.doPost(WebRenderServlet.java:189)
      	at javax.servlet.http.HttpServlet.service(HttpServlet.java:650)
      	at javax.servlet.http.HttpServlet.service(HttpServlet.java:731)
      	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:303)
      	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
      	at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
      	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
      	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
      	at org.openvpms.web.echo.servlet.Log4JMDCUserFilter.doFilter(Log4JMDCUserFilter.java:58)
      	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
      	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
      	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)
      	at org.springframework.security.web.access.intercept.FilterSecurityInterceptor.invoke(FilterSecurityInterceptor.java:118)
      	at org.springframework.security.web.access.intercept.FilterSecurityInterceptor.doFilter(FilterSecurityInterceptor.java:84)
      	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
      	at org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:113)
      	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
      	at org.springframework.security.web.session.SessionManagementFilter.doFilter(SessionManagementFilter.java:103)
      	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
      	at org.springframework.security.web.authentication.AnonymousAuthenticationFilter.doFilter(AnonymousAuthenticationFilter.java:113)
      	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
      	at org.springframework.security.web.servletapi.SecurityContextHolderAwareRequestFilter.doFilter(SecurityContextHolderAwareRequestFilter.java:154)
      	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
      	at org.springframework.security.web.savedrequest.RequestCacheAwareFilter.doFilter(RequestCacheAwareFilter.java:45)
      	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
      	at org.springframework.security.web.authentication.AbstractAuthenticationProcessingFilter.doFilter(AbstractAuthenticationProcessingFilter.java:199)
      	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
      	at org.springframework.security.web.context.request.async.WebAsyncManagerIntegrationFilter.doFilterInternal(WebAsyncManagerIntegrationFilter.java:50)
      	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:106)
      	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
      	at org.springframework.security.web.context.SecurityContextPersistenceFilter.doFilter(SecurityContextPersistenceFilter.java:87)
      	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
      	at org.springframework.security.web.FilterChainProxy.doFilterInternal(FilterChainProxy.java:192)
      	at org.springframework.security.web.FilterChainProxy.doFilter(FilterChainProxy.java:160)
      	at org.springframework.web.filter.DelegatingFilterProxy.invokeDelegate(DelegatingFilterProxy.java:343)
      	at org.springframework.web.filter.DelegatingFilterProxy.doFilter(DelegatingFilterProxy.java:260)
      	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
      	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
      	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:220)
      	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:122)
      	at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:505)
      	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:170)
      	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:103)
      	at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:957)
      	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:116)
      	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:423)
      	at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1079)
      	at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:620)
      	at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:318)
      	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
      	at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
      	at java.lang.Thread.run(Thread.java:748)
      Caused by: java.lang.NullPointerException
      	at org.openvpms.smartflow.client.ErrorResponseFilter.filter(ErrorResponseFilter.java:68)
      	at org.glassfish.jersey.client.ClientFilteringStages$ResponseFilterStage.apply(ClientFilteringStages.java:140)
      	at org.glassfish.jersey.client.ClientFilteringStages$ResponseFilterStage.apply(ClientFilteringStages.java:128)
      	at org.glassfish.jersey.process.internal.Stages.process(Stages.java:171)
      	at org.glassfish.jersey.client.ClientRuntime.invoke(ClientRuntime.java:260)
      

        Attachments

          Activity

            People

            • Assignee:
              tanderson Tim Anderson
              Reporter:
              tanderson Tim Anderson
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 3h
                3h

                  Who's Looking?